[Kde-pim] Review Request 123625: Kolab patches: korganizer (new files) [1/2]

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123625/#review80007
-----------------------------------------------------------



korganizer/views/collectionview/calendardelegate.cpp (line 147)
<https://git.reviewboard.kde.org/r/123625/#comment54883>

    Perhaps remove duplicate check.
    If( !isTopLEvelSearch) {
       if (!istoplevelkolabl) {
           button<<...;
       }
       if (issearch) {
           button<<.
       }
    }



korganizer/views/collectionview/controller.cpp (line 66)
<https://git.reviewboard.kde.org/r/123625/#comment54885>

    switch(role) {
    }
    better to know if we forgot enum type.



korganizer/views/collectionview/controller.cpp (line 151)
<https://git.reviewboard.kde.org/r/123625/#comment54887>

    switch(role) {
    }



korganizer/views/collectionview/controller.cpp (line 168)
<https://git.reviewboard.kde.org/r/123625/#comment54886>

    (Person %1", mPerson.name)



korganizer/views/collectionview/quickview.h (line 49)
<https://git.reviewboard.kde.org/r/123625/#comment54888>

    Q_SLOTS



korganizer/views/collectionview/quickview.cpp (line 76)
<https://git.reviewboard.kde.org/r/123625/#comment54889>

    it compiles without QStringLiteral around color ?
    QColor(QStringLiteral("..."))



korganizer/views/collectionview/quickview.cpp (line 115)
<https://git.reviewboard.kde.org/r/123625/#comment54890>

    Remove it


- Laurent Montel


On mai 6, 2015, 12:32 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123625/
> -----------------------------------------------------------
> 
> (Updated mai 6, 2015, 12:32 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * Create Event/Note/Todo of of Event/Todo (noteeditdialog)
> * new collectionview (views/collectionview)
> * search for open/decliend Invitations (searchcollectionhelper)
> 
> 
> Diffs
> -----
> 
>   korganizer/CMakeLists.txt 1cc701b93d2ac735fbde2ba3ed13cbc917659a23 
>   korganizer/autotests/CMakeLists.txt c04d61afd0a1ad31fa6a2cebedb7d78880c61fe5 
>   korganizer/autotests/koeventpopupmenutest.h PRE-CREATION 
>   korganizer/autotests/koeventpopupmenutest.cpp PRE-CREATION 
>   korganizer/autotests/noteeditdialogtest.h PRE-CREATION 
>   korganizer/autotests/noteeditdialogtest.cpp PRE-CREATION 
>   korganizer/noteeditdialog.h PRE-CREATION 
>   korganizer/noteeditdialog.cpp PRE-CREATION 
>   korganizer/searchcollectionhelper.h PRE-CREATION 
>   korganizer/searchcollectionhelper.cpp PRE-CREATION 
>   korganizer/views/collectionview/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/autotests/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/autotests/modeltest.h PRE-CREATION 
>   korganizer/views/collectionview/autotests/modeltest.cpp PRE-CREATION 
>   korganizer/views/collectionview/autotests/reparentingmodeltest.cpp PRE-CREATION 
>   korganizer/views/collectionview/calendardelegate.h PRE-CREATION 
>   korganizer/views/collectionview/calendardelegate.cpp PRE-CREATION 
>   korganizer/views/collectionview/controller.h PRE-CREATION 
>   korganizer/views/collectionview/controller.cpp PRE-CREATION 
>   korganizer/views/collectionview/icons/128-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/16-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/22-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/256-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/32-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/48-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/64-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/icons/sc-apps-quickview.svgz PRE-CREATION 
>   korganizer/views/collectionview/quickview.h PRE-CREATION 
>   korganizer/views/collectionview/quickview.cpp PRE-CREATION 
>   korganizer/views/collectionview/quickview.ui PRE-CREATION 
>   korganizer/views/collectionview/reparentingmodel.h PRE-CREATION 
>   korganizer/views/collectionview/reparentingmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/