[Kde-pim] Review Request 123681: Fix build with Qt 5.5

[Aleix Pol Gonzalez]

> On May 8, 2015, 2:22 p.m., Christian Mollekopf wrote:
> > Using something like:
> > 
> > std::transform(flags.begin(), flags.end(), flags.begin(), boost::bind(static_cast<void(QByteArray::*)() const>(&QByteArray::toLower), _1));
> > 
> > doesn't work?
> > 
> > If not you can go ahead from my side with what you did.

Nope

compiling listjob.cpp (c++)
/home/kde-devel/frameworks/kimap/src/listjob.cpp: In member function ‘virtual void KIMAP::ListJob::handleResponse(const KIMAP::Message&)’:
/home/kde-devel/frameworks/kimap/src/listjob.cpp:181:142: error: no matches converting function ‘toLower’ to type ‘void (class QByteArray::*)() const’
             std::transform(flags.begin(), flags.end(), flags.begin(), std::bind(static_cast<void(QByteArray::*)() const>(&QByteArray::toLower), _1));
                                                                                                                                              ^
In file included from /home/kde-devel/kde5/include/QtCore/qstring.h:42:0,
                 from /home/kde-devel/kde5/include/QtCore/qobject.h:41,
                 from /home/kde-devel/kde5/include/QtCore/QObject:1,
                 from /home/kde-devel/kde5/include/KF5/KCoreAddons/kjob.h:26,
                 from /home/kde-devel/kde5/include/KF5/KCoreAddons/KJob:1,
                 from /home/kde-devel/frameworks/kimap/src/job.h:25,
                 from /home/kde-devel/frameworks/kimap/src/listjob.h:25,
                 from /home/kde-devel/frameworks/kimap/src/listjob.cpp:20:
/home/kde-devel/kde5/include/QtCore/qbytearray.h:262:16: note: candidates are: QByteArray QByteArray::toLower() &&
     QByteArray toLower() && Q_REQUIRED_RESULT
                ^
/home/kde-devel/kde5/include/QtCore/qbytearray.h:260:16: note:                 QByteArray QByteArray::toLower() const &
     QByteArray toLower() const & Q_REQUIRED_RESULT
                ^


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123681/#review80085
-----------------------------------------------------------


On May 8, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123681/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 2:02 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Christian Mollekopf and Laurent Montel.
> 
> 
> Repository: kimap
> 
> 
> Description
> -------
> 
> Now QByteArray::toLower is overloaded. I didn't manage to tell bind what version to use.
> I spent some time (more than I'd care to admit, in fact) trying to work it out but didn't manage, so did this which works and it's probably even more readable.
> 
> 
> Diffs
> -----
> 
>   src/listjob.cpp eebd404 
> 
> Diff: https://git.reviewboard.kde.org/r/123681/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/