[Kde-pim] Review Request 123612: KF5: Remove use of KCalendarSystem

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123612/#review80799
-----------------------------------------------------------

Ship it!



src/parsers/plan2/holidayparserdriverplan.cpp (lines 166 - 169)
<https://git.reviewboard.kde.org/r/123612/#comment55390>

    This should probably have 4 indent spaces ;)



src/parsers/plan2/holidayparserdriverplan.cpp (line 262)
<https://git.reviewboard.kde.org/r/123612/#comment55391>

    This link is no longer valid...probably not a big deal, but just sayin ;)



src/parsers/plan2/holidayparserdriverplan.cpp (lines 415 - 416)
<https://git.reviewboard.kde.org/r/123612/#comment55392>

    Also 4 spaces


- Martin Klapetek


On May 3, 2015, 8:20 p.m., John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123612/
> -----------------------------------------------------------
> 
> (Updated May 3, 2015, 8:20 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kholidays
> 
> 
> Description
> -------
> 
> Switch from KCalendarSystem to QCalendarSystem to remove the dependency
> on kdelibs4support.
> 
> 
> Diffs
> -----
> 
>   autotests/testholidayregion.cpp a01ddacdac28ce85d68a27ba485dfa5578525320 
>   src/holidayregion.h 0b45e9802f4bc511b83458ce05f488713d6bc5ae 
>   src/holidayregion.cpp e35035a4e4c4e9b0f8058eefa735ca85a0032609 
>   src/parsers/holidayparserdriver.cpp 32bfa541c22468c835fa44afd569309b0b38bb74 
>   src/parsers/holidayparserdriver_p.h ba0cf38aca3d473543dc87980216dd54dde0183d 
>   src/parsers/plan2/holidayparserdriverplan.cpp 132548131a2c65022f26af1936760479b2783720 
>   src/parsers/plan2/holidayparserdriverplan_p.h e4fcef7095128e972740a10bdb52ab7944d60ac0 
> 
> Diff: https://git.reviewboard.kde.org/r/123612/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Layt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/