[Kde-pim] Review Request 123774: Port PIM applications to new PimUniqueApplication API

Daniel Vrátil dvratil at kde.org
Wed May 13 15:02:13 BST 2015 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123774/
-----------------------------------------------------------

(Updated May 13, 2015, 4:02 p.m.)


Review request for KDEPIM and Laurent Montel.


Repository: kdepim


Description
-------

Switching PimUniqueApplication from KUniqueApplication to QApplication means that we have to ditch some KDELibs4Support components - mostly it means switching to QCommandLineParser and KAboutData. We also must make sure that there are no kapp (or KApplication::instance()) calls in those apps, as that returns null pointer now.

In case of Kontact I decided to port it to PimUniqueApplication too, as that gives us nice feature: switching Kontact modules from commandline (e.g. running kontact --module kmailplugin will switch to KMail in a running instance of Kontact).

see dev/no-kuniqueapplication for individual commits


Diffs
-----

  CMakeLists.txt ec3a582177b93416722e1c95381952531fe05ae5 
  akregator/kontactplugin/akregator_plugin.h 66bc79a12d6bb9a67b78941175ee25f71b2cb1fe 
  akregator/kontactplugin/akregator_plugin.cpp 04de98dbd44d3b6d930bf9f8e3b3e5316179cfc9 
  akregator/kontactplugin/akregatorplugin.desktop 74f2b7c4fe02c5c99b74db2fcf6ed7929e15d2af 
  akregator/src/aboutdata.h d978c347be191caf86cfb0374c57ddb890b4a2d1 
  akregator/src/aboutdata.cpp d3877b9c64c8d5a615098d04db4fb4dc52f4002b 
  akregator/src/akregator_options.h 713d5905f855c96b78e8e87fa7b89e554f018155 
  akregator/src/akregator_part.h 466ddb3d9f25c8afe577ca3a039256861a0f751e 
  akregator/src/akregator_part.cpp 59ff823074dd60d752d4e4ae46bf353b76b8869c 
  akregator/src/articleviewer.cpp bbc7aee550d1a3e7d9a1e850ad7546208f2474e2 
  akregator/src/main.cpp 44eda7672699fedc413df4c2e354b5274f91a801 
  akregator/src/mainwindow.cpp ef409977701b8b5422ff7f0c0b5fba6ab89851c7 
  akregator/src/org.kde.akregator.part.xml bcfd0aff014f2e8cd45d1d0b7992a0511c71da54 
  akregator/src/tabwidget.cpp 9c6b020118366b8b71917fc67c5001e3c8e00f4e 
  kaddressbook/aboutdata.h 5d51fc973d30643e5785682eec6aeec5f049474e 
  kaddressbook/aboutdata.cpp 0b12c8108dc00a3a079111d520d32687b7d090cc 
  kaddressbook/gravatar/gravatarcreatejob.h b7d3bf35bef5a0554f3af16619f3d84bb7a4eddd 
  kaddressbook/gravatar/gravatarcreatejob.cpp 573b4541d7040427eb759b4c770520dcff530840 
  kaddressbook/gravatar/gravatarupdatejob.cpp c9603e91a1fc345c65a786ae06da02e5f0d7998b 
  kaddressbook/kaddressbook_options.h c22acff8554d3c59dd9ee6831eb8268b4dacdb06 
  kaddressbook/kontactplugin/CMakeLists.txt 58475fc090a6647f174efc8cc7abb7060648c567 
  kaddressbook/kontactplugin/kaddressbook_plugin.h 071a3e042ea54e390dbb8f3659e151054d622af5 
  kaddressbook/kontactplugin/kaddressbook_plugin.cpp fa6d73816ea26096ebf50dfeb2809578f2d519c5 
  kaddressbook/main.cpp cc41665c3344580ca60d053f97b06fb30697e9ed 
  kaddressbook/mainwidget.h 8bade94285fbdf7ce6caf3a74d61ff2de28d9b8f 
  kaddressbook/mainwidget.cpp 362a0f18e6d363172e736f207a656ef3ba52e42f 
  kaddressbook/org.kde.kaddressbook.xml 1415b67a727890d2782698c4aa56e9fbde971dcb 
  kmail/aboutdata.h 60a62ec0e80debfd573534c840df907024f982be 
  kmail/aboutdata.cpp d252f94b742f2f0b94a037eea1ce577b6e411b9b 
  kmail/editor/kmcomposewin.cpp f14683f70bd52a150a0183c6f31124cf3e95bc07 
  kmail/kmail_options.h 3735fbe699556f117e24c16e7b4958370d9026b4 
  kmail/kmkernel.h 084179891c10d6f311fb2c1cf128e16029e0d91a 
  kmail/kmkernel.cpp f68b57c69ecaf962b3a6578b30246b5e915bb8be 
  kmail/kmmainwin.cpp 120a31f4176c8f09d960792cb098bee8ece2ef3f 
  kmail/kontactplugin/kmail_plugin.h 4a4a4e19f70c51d448b6568ef6dec9b4846f5793 
  kmail/kontactplugin/kmail_plugin.cpp a710d8dc5d7da7379353df4dd057676eb1b86770 
  kmail/main.cpp 7c15c07d98f398365873891cb289673cb6be146f 
  knotes/apps/application.h 4b4b9478a72bf62093bbe72ac104860fbf629ed5 
  knotes/apps/application.cpp 69ae117a774daf6a24cbb338c1769aa8c0256ae9 
  knotes/apps/knotes_options.h 5eae86cf08e1f2e8bd4b91b1ca1ae399c4391555 
  knotes/apps/knotesapp.cpp ebe6cf08623c9eea3880c5ec06542a9071164da8 
  knotes/apps/main.cpp abf76f56cb31e3ec86983b07d9646b12838b3fc9 
  knotes/kontactplugin/knotes_plugin.h 9fc0c8a92df5f52c51d072a1c860aa477efcbc5a 
  knotes/kontactplugin/knotes_plugin.cpp 5097824e4c0798689f1699ce3084b7597c812b9c 
  knotes/kontactplugin/knotesplugin.desktop 9c319050728a1bfffb052b7262f9bc095ff72a9f 
  knotes/notes/knote.cpp 4bc9ff8426d6ee1336d7ca989f961729d9137c51 
  kontact/src/CMakeLists.txt 1153224abaa38fab8d5fdb9fefe870577150d41b 
  kontact/src/main.cpp 11dafe0542aebcdaea71bbc30a5fb093738ae930 
  kontact/src/mainwindow.cpp 4dbc8c8cbcc3219940fe9356c278d372ba678781 
  korganizer/aboutdata.h 457152ddd86f6d93849284b47b9bf5b9af744c17 
  korganizer/aboutdata.cpp 87bf4b75c9b749f40d75fbb1a2aed3d6d4975963 
  korganizer/actionmanager.h 4f537d85e024cbd55d4dd634182b4ee6e3fdb737 
  korganizer/actionmanager.cpp 287a5f7bb3d60d8b3a6d057ce8431052b5323e16 
  korganizer/data/org.kde.korganizer.Korganizer.xml 7f3a187de49dfad2a5ebac3a6384828baa61a904 
  korganizer/impl/korganizerifaceimpl.h 7ce859922b303f0773e35c9bb534fc7252ffa6aa 
  korganizer/impl/korganizerifaceimpl.cpp 2dd1f8a6f738d5a2614b3529f4d822d389d0e164 
  korganizer/koapp.h 2ae1db26f0d4ee81d9c27a62b4097b0794094fe8 
  korganizer/koapp.cpp a3cb8646a8f4a22c2ec99e7e52ad751530c753e2 
  korganizer/kontactplugin/korganizer/CMakeLists.txt 5028863bc251b580d7418d2f1678bfc669ee1fde 
  korganizer/kontactplugin/korganizer/korg_uniqueapp.h 938474241a4524c5a240ac8c50080e03d1c26f48 
  korganizer/kontactplugin/korganizer/korg_uniqueapp.cpp fbea097b3fba4f097d89ba07134c1a9324b9a64a 
  korganizer/korganizer_options.h 0d39683c96bc47ca3e66c0f6c5d9718c00cd0bfd 
  korganizer/korganizer_part.cpp 14c88012f8b2995c06fc5b4a57a7d5786f64f111 
  korganizer/main.cpp a0410f5e09a558a1e14d1f0d6ae2efba9823b3af 
  messageviewer/scamdetection/scamcheckshorturl.cpp ef903cc88eaf3c4f49dac7ec49322f3848fa402c 
  messageviewer/settings/messageviewer.kcfg.cmake 1b0d50163d48b6442b3386abd19f7a2c1c558462 
  pimcommon/CMakeLists.txt d87515d60b17f1505cd8949b4e4137b7af80e151 
  pimcommon/gravatar/autotests/CMakeLists.txt PRE-CREATION 
  pimcommon/gravatar/autotests/gravatardownloadpixmapwidgettest.h PRE-CREATION 
  pimcommon/gravatar/autotests/gravatardownloadpixmapwidgettest.cpp PRE-CREATION 
  pimcommon/gravatar/autotests/gravatarresolvurljobtest.h PRE-CREATION 
  pimcommon/gravatar/autotests/gravatarresolvurljobtest.cpp PRE-CREATION 
  pimcommon/gravatar/gravatarresolvurljob.h b56f9b1040349a43596509565324753fd7b5cf2c 
  pimcommon/gravatar/gravatarresolvurljob.cpp c850a157658652551fe44b550b2ab791633566e6 
  pimcommon/gravatar/tests/CMakeLists.txt PRE-CREATION 
  pimcommon/gravatar/tests/gravatarwidget_gui.cpp PRE-CREATION 
  pimcommon/gravatar/widgets/gravatardownloadpixmapwidget.h PRE-CREATION 
  pimcommon/gravatar/widgets/gravatardownloadpixmapwidget.cpp PRE-CREATION 
  pimsettingexporter/CMakeLists.txt 369df3f7a262c68f979fe02ad928e290f2c5e36b 
  pimsettingexporter/abstractimportexportjob.cpp a986e43a79d747eeaf0342d5ff9be86b67dd9584 
  pimsettingexporter/gui/CMakeLists.txt b1341f4924c3afb705c8887ae75a4c2a7c498142 
  pimsettingexporter/gui/dialog/backupfilestructureinfodialog.h 99abe5ed4e0c6924b8f2273019e26fc22f73e339 
  pimsettingexporter/gui/dialog/backupfilestructureinfodialog.cpp  
  pimsettingexporter/gui/dialog/selectiontypedialog.h ea6e6fddeddeeaaed0492271346becb8134b6ef0 
  pimsettingexporter/gui/dialog/selectiontypedialog.cpp 392e195d663861e62ef408ae4ea4f27a8df34aca 
  pimsettingexporter/gui/dialog/showarchivestructuredialog.h fd1652613e22c0260b7d0875ea93a25ddc1949c5 
  pimsettingexporter/gui/dialog/showarchivestructuredialog.cpp  
  pimsettingexporter/gui/pimsettingexporterwindow.h 71b143214b0ecfb4db23f286916cf8d3d161f115 
  pimsettingexporter/gui/widgets/logwidget.h 6ad544ccb8103b4da74832ddeaaee467d83882d8 
  pimsettingexporter/gui/widgets/logwidget.cpp  
  pimsettingexporter/gui/widgets/selectiontypetreewidget.h  
  pimsettingexporter/gui/widgets/selectiontypetreewidget.cpp  
  pimsettingexporter/tests/CMakeLists.txt 2864249b69a2f47ef81cfb1d673cdc3532058c0e 
  pimsettingexporter/tests/selectiontreewidget_gui.cpp 809c6d4dc5bed1b4d3ec57579c6fcb97d85e8e2e 
  pimsettingexporter/tests/showarchivestructuredialog_gui.cpp 858776b0c06b4637d6fd51a87ea12ac62a3feffa 
  pimsettingexporter/utils.h ab79f9a8c1d521818d3588a308c27a73ebc128ab 
  pimsettingexporter/xml/templateselection.h 4a1df50237dd52544cdf705cd225c4203336008a 

Diff: https://git.reviewboard.kde.org/r/123774/diff/


Testing (updated)
-------

- start $PIMapp
- minimize it
- run $PIMapp from terminal
- the running instance is restored, the new instance quits immediatelly


- start Kontact
- rum $PIMapp from terminal
- Kontact is restored and switches to respective module


- start $PIMapp
- minimize it
- start Kontact
- select $PIMapp in Kontact
- $PIMapp window is opened
- select another app in Kontact
- quit $PIMapp
- select $PIMapp in Kontact
- $PIMapp is loaded in Kontact


Thanks,

Daniel Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list