[Kde-pim] Review Request 123109: Fix assert when ETM is monitoring one specific collection.

David Faure faure at kde.org
Sun Mar 29 13:32:50 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123109/
-----------------------------------------------------------

(Updated March 29, 2015, 12:32 p.m.)


Review request for KDEPIM-Libraries and Christian Mollekopf.


Changes
-------

Implement Christian's suggestion, better for catching possible bugs in the other cases, indeed.


Summary (updated)
-----------------

Fix assert when ETM is monitoring one specific collection.


Repository: kdepimlibs


Description (updated)
-------

Since 58af6d2ca8194, this sets it as the root of the model.
So if the collection itself changes, the associated index is the invalid index.

REVIEW: 123109


Diffs (updated)
-----

  akonadi/entitytreemodel_p.cpp 6800a8659e59b36472380d22968c341913a1a5bb 

Diff: https://git.reviewboard.kde.org/r/123109/diff/


Testing
-------

This was asserting, in the test app I'm writing, where the ETM is created with only one specific collection to monitor.


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list