[Kde-pim] Review Request 122827: Fix the build using MSVC 2013.

[Cristian Oneț]

> On March 6, 2015, 7:23 a.m., Laurent Montel wrote:
> > I don't use windows.
> > So if it fixes for windows and that you verified that on linux it still builds
> > I can told you "ship it"

Since both changes are in between if(WIN32) cmake checks I can say that the linux build is not affected even without testing it. I've also added the kdewin group as reviewers.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122827/#review77088
-----------------------------------------------------------


On March 5, 2015, 4:56 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122827/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 4:56 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: gpgmepp
> 
> 
> Description
> -------
> 
> The KDEWin library is needed on Windows because gpgmepp uses POSIX
> types like ssize_t which are not available by default and are provided
> by this library of the KDE on Windows project. Ideally gpgmepp should
> not use platform dependent types and should solve this the way gpgme
> does.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8d3b0d977905ab9905be809ab2869186acde30bf 
>   src/qgpgme/CMakeLists.txt 39ebf32bcbdce73223424664b319b4666f30142e 
> 
> Diff: https://git.reviewboard.kde.org/r/122827/diff/
> 
> 
> Testing
> -------
> 
> Built and used the library in KMyMoney using MSVC 2013.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/