[Kde-pim] Review Request 122940: Patch to fix build on OSX 10.9
Allen Winter
winter at kde.org
Sun Mar 15 14:11:28 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122940/#review77518
-----------------------------------------------------------
I'm not strongly opposed to committing this into KDE4 and/or Frameworks, but I wonder why it is needed. Seems like the compiler should be happy with the code as is.
- Allen Winter
On March 14, 2015, 12:45 p.m., Marko Käning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122940/
> -----------------------------------------------------------
>
> (Updated March 14, 2015, 12:45 p.m.)
>
>
> Review request for KDEPIM, Laurent Montel and René J.V. Bertin.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> The MacPorts' ticket [#47087](http://trac.macports.org/ticket/47087) describes the details and offers this patch.
>
> * Has this code already made it into KF5?
> * And if so, which frameworks contains this code now? Does it still need fixing there?
>
> Thanks, René, for supplying the patch.
>
>
> Diffs
> -----
>
> blogilo/src/blogger.h 9e9da5208d1f28d19c03c1e5d06f44dc3bafa3fe
>
> Diff: https://git.reviewboard.kde.org/r/122940/diff/
>
>
> Testing
> -------
>
> Builds fine on MacPorts. Refer to above ticket.
>
>
> Thanks,
>
> Marko Käning
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list