[Kde-pim] Review Request 122961: Pipe Through Filter: Do not change mail

Sandro Knauß knauss at kolabsys.com
Sat Mar 14 23:21:06 GMT 2015



> On März 14, 2015, 9:38 nachm., Laurent Montel wrote:
> > mailcommon/filter/tests/actionpipethrough.cpp, line 76
> > <https://git.reviewboard.kde.org/r/122961/diff/1/?file=354952#file354952line76>
> >
> >     I prefere that we don't have existing email/name.
> >     please use foo at kde.org for example etc.

Well actually this mail is a copy of rfc 2046


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122961/#review77481
-----------------------------------------------------------


On März 14, 2015, 8:36 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122961/
> -----------------------------------------------------------
> 
> (Updated März 14, 2015, 8:36 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 331991
>     http://bugs.kde.org/show_bug.cgi?id=331991
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> For signed mails the body of the mail has not to change not even slightly.
> 
> BUG: 331991
> FIXED-IN: 15.04
> 
> 
> Diffs
> -----
> 
>   mailcommon/filter/filteractions/filteractionwithcommand.cpp 7b267d9e79f4047c2e621c797bbd6c1c2376eca1 
>   mailcommon/filter/tests/CMakeLists.txt cd149916002ab6976595abba407f5fa3db943c16 
>   mailcommon/filter/tests/actionpipethrough.h PRE-CREATION 
>   mailcommon/filter/tests/actionpipethrough.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122961/diff/
> 
> 
> Testing
> -------
> 
> Adding tests for making sure that pipe through do not change the content of a mail unexpected.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list