[Kde-pim] Review Request 123129: Centralize the cmake code for generating services and providers
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Mar 25 21:16:02 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123129/
-----------------------------------------------------------
(Updated March 25, 2015, 10:16 p.m.)
Review request for KDEPIM and Telepathy.
Repository: kaccounts-integration
Description
-------
I wanted to fix the code to generate it at build time rather than configure time, I saw the code was copypasted both in kaccounts-providers and ktp-accounts-kcm.
If we get this in, I can look into doing the generation properly.
Diffs (updated)
-----
src/lib/CMakeLists.txt ddd79b7
src/lib/KAccountsConfig.cmake.in ffc6cb5
src/lib/KAccountsMacros.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123129/diff/
Testing
-------
Changed it in both places, still works.
Thanks,
Aleix Pol Gonzalez
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list