[Kde-pim] Review Request 122940: Patch to fix build on OSX 10.9

[Sandro Knauß]

Hey,

> That's not very efficient, the software could at least allow others to
> upload attachments ...
> 
> There's a kde-mac group. Can "kde-mac" also act as a RR author so that
> (select) group members can share the credentials and truly collaborate on
> updating review requests?

Well i don't know. I think if the kde-mac group uses one rb account this could 
work. But if this is possible or any other solutions could work - You/your 
group should discuss your needs with the sysadmins 
https://sysadmin.kde.org/tickets/.

But let's move the discussion in anycase out of this bugreport :)

Regads,

sandro

--
Amhttps://sysadmin.kde.org/tickets/ Freitag, 20. März 2015, 12:23:15 schrieb 
René J.V. Bertin:
> > On March 15, 2015, 3:38 p.m., Allen Winter wrote:
> > > Renee, how about matching the implementation signature in blogger.cpp,
> > > i.e. use the typedef in blogger.cpp as well.  else it will probably
> > > confuse doxygen or someone else later on who will decide to matchup the
> > > signatures.> 
> > Marko Käning wrote:
> >     Sound't like a good plan.
> >     
> >     Talking about later... Where is this code in KF5 by now, Allen?
> > 
> > René J.V. Bertin wrote:
> >     --e please, as I'm still male last I checked :P
> >     
> >     No problem as far as I'm concerned to update blogger.cpp too. In fact
> >     it's surprising that this isn't necessary.
> >     
> >     NB: my name is on this RR because I suggested the patch on a bug
> >     tracker, the reporter then reported back that it solved the build
> >     issue, and Marko then submitted the patch to RB. Credit where credit
> >     is due - I'm just the brains on this one, not the author ;)> 
> > Marko Käning wrote:
> >     Without brains no authorship. ;)
> >     
> >     I considered myself here only as the messenger! =)
> > 
> > René J.V. Bertin wrote:
> >     I've prepared a new patch, but can apparently only upload it as an
> >     inline comment?
> >     
> >     Is there a way to set up this RR so that I too can at least upload
> >     attachments?> 
> > Sandro Knauß wrote:
> >     Well you are not (marked) as the autor of this RR, so either you
> >     upload a new RR yourself or give the new patch to Marko, so he can
> >     update the RR.
> That's not very efficient, the software could at least allow others to
> upload attachments ...
> 
> There's a kde-mac group. Can "kde-mac" also act as a RR author so that
> (select) group members can share the credentials and truly collaborate on
> updating review requests?
> 
> 
> - René J.V.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122940/#review77524
> -----------------------------------------------------------
> 
> On March 14, 2015, 1:45 p.m., Marko Käning wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/122940/
> > -----------------------------------------------------------
> > 
> > (Updated March 14, 2015, 1:45 p.m.)
> > 
> > 
> > Review request for KDEPIM, Laurent Montel and René J.V. Bertin.
> > 
> > 
> > Repository: kdepim
> > 
> > 
> > Description
> > -------
> > 
> > The MacPorts' ticket [#47087](http://trac.macports.org/ticket/47087)
> > describes the details and offers this patch.> 
> >  * Has this code already made it into KF5?
> >  * And if so, which frameworks contains this code now? Does it still need
> >  fixing there?> 
> > Thanks, René, for supplying the patch.
> > 
> > 
> > Diffs
> > -----
> > 
> >   blogilo/src/blogger.h 9e9da5208d1f28d19c03c1e5d06f44dc3bafa3fe
> > 
> > Diff: https://git.reviewboard.kde.org/r/122940/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Builds fine on MacPorts. Refer to above ticket.
> > 
> > 
> > Thanks,
> > 
> > Marko Käning

-- 
Sandro Knauß
Software Developer

Kolab Systems AG
Zürich, Switzerland

e: knauss at kolabsystems.com
t: +41 43 501 66 91
w: https://kolabsystems.com

pgp: CE81539E Sandro Knauß
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20150320/ee30b5b0/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/