[Kde-pim] Review Request 122940: Patch to fix build on OSX 10.9

[Marko Käning]

> On March 15, 2015, 3:11 p.m., Allen Winter wrote:
> > I'm not strongly opposed to committing this into KDE4 and/or Frameworks, but I wonder why it is needed.  Seems like the compiler should be happy with the code as is.
> 
> Marko Käning wrote:
>     Hi Allen, well, without the patch the compiler gives you this:
>     ```
>     :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_kde_kdepim4/kdepim4/work/kdepim-4.14.3/blogilo/src/blogger.h:96:85: error: expected ')'
>     :info:build     void authenticate(const QMap<QString, QString> &authData = QMap<QString, QString>());
>     :info:build                                                                                     ^
>     :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_kde_kdepim4/kdepim4/work/kdepim-4.14.3/blogilo/src/blogger.h:96:22: note: to match this '('
>     :info:build     void authenticate(const QMap<QString, QString> &authData = QMap<QString, QString>());
>     :info:build                      ^
>     :info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_kde_kdepim4/kdepim4/work/kdepim-4.14.3/blogilo/src/blogger.h:96:76: error: expected '>'
>     :info:build     void authenticate(const QMap<QString, QString> &authData = QMap<QString, QString>());
>     :info:build                                                                            ^
>     :info:build 2 errors generated.
>     :info:build make[2]: *** [blogilo/src/CMakeFiles/blogilo.dir/bilboblog.o] Error 1
>     :info:build make[2]: *** Waiting for unfinished jobs....
>     ```
>     and I don't know how to avoid this on OSX when using Apple's clang.
>     Greets, Marko
> 
> Laurent Montel wrote:
>     I am not against but it's wierd that clang doesn't support it.
>     it's standard as code no ?

As I am not a C++ professional I can't give you an answer as to why the above code fails on OSX' clang. It does though. =/


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122940/#review77518
-----------------------------------------------------------


On March 14, 2015, 1:45 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122940/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 1:45 p.m.)
> 
> 
> Review request for KDEPIM, Laurent Montel and René J.V. Bertin.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The MacPorts' ticket [#47087](http://trac.macports.org/ticket/47087) describes the details and offers this patch.
> 
>  * Has this code already made it into KF5?
>  * And if so, which frameworks contains this code now? Does it still need fixing there?
> 
> Thanks, René, for supplying the patch.
> 
> 
> Diffs
> -----
> 
>   blogilo/src/blogger.h 9e9da5208d1f28d19c03c1e5d06f44dc3bafa3fe 
> 
> Diff: https://git.reviewboard.kde.org/r/122940/diff/
> 
> 
> Testing
> -------
> 
> Builds fine on MacPorts. Refer to above ticket.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/