[Kde-pim] Review Request 122892: OpenChange should be als "required"

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122892/#review77568
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/122892/#comment53284>

    If libmapi is required in order to successfully compile akonadi-exchange, then
    
        find_package(OpenChange REQUIRED)
    
    should be used, instead of `macro_optional_find_package`.
    
    Same applies for Samba below.


- Daniel Vrátil


On March 10, 2015, 6:58 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122892/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 6:58 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi-exchange
> 
> 
> Description
> -------
> 
> As I don't have the OpenChange package (under ArchLinux) installed,
> I get only an error from cmake:
> CMake Warning at CMakeLists.txt:26 (message):
>    Exchange needs OpenChange MAPI Client Library.
> The process goes on:
> -- Generating done
> -- Build files have been written to: /home/guy-kde/build/5/playground/pim/akonadi-exchange
> 
> But the generated files aren't correct.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eabc546 
> 
> Diff: https://git.reviewboard.kde.org/r/122892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/