[Kde-pim] Review Request 123029: LDAP settings: add user-configurable filter.

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123029/#review77711
-----------------------------------------------------------

Ship it!


If you split it to two commits, you can ship it. The patch looks good


libkdepim/ldap/ldapclient.cpp
<https://git.reviewboard.kde.org/r/123029/#comment53332>

    Please make sure that you move these cleanups into an single commit.


- Sandro Knauß


On März 18, 2015, 4:50 nachm., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123029/
> -----------------------------------------------------------
> 
> (Updated März 18, 2015, 4:50 nachm.)
> 
> 
> Review request for KDEPIM, Sandro Knauß and Patrick Spendrin.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This is useful to filter on a given nsRole for instance, so that
> one gets only colleagues in his completion, not everyone with a LDAP
> account including customers having access to some company services.
> 
> 
> Diffs
> -----
> 
>   libkdepim/ldap/addhostdialog.cpp 59c2e3e8fdbac75e1cbd1241a9b028f95db540c5 
>   libkdepim/ldap/ldapclient.cpp a1df6fdad4e9e191cbeff327a440a3f6cff273f2 
>   libkdepim/ldap/ldapclientsearchconfig.cpp 8be8df6fc6584d0359752d0c097de5b002888d7e 
> 
> Diff: https://git.reviewboard.kde.org/r/123029/diff/
> 
> 
> Testing
> -------
> 
> Tested on the KDAB server.
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/