[Kde-pim] Review Request 122961: Pipe Through Filter: Do not change mail

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122961/#review77481
-----------------------------------------------------------



mailcommon/filter/filteractions/filteractionwithcommand.cpp
<https://git.reviewboard.kde.org/r/122961/#comment53209>

    why don't add directly !msgtext.trimmed().isEmpty ?



mailcommon/filter/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122961/#comment53210>

    Please move it in autotests directly.
    It will more easy when merge in kf5



mailcommon/filter/tests/actionpipethrough.h
<https://git.reviewboard.kde.org/r/122961/#comment53211>

    Please add a constructor even if it's empty.



mailcommon/filter/tests/actionpipethrough.cpp
<https://git.reviewboard.kde.org/r/122961/#comment53212>

    Move to the end of file.



mailcommon/filter/tests/actionpipethrough.cpp
<https://git.reviewboard.kde.org/r/122961/#comment53213>

    I prefere that we don't have existing email/name.
    please use foo at kde.org for example etc.


- Laurent Montel


On mars 14, 2015, 8:36 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122961/
> -----------------------------------------------------------
> 
> (Updated mars 14, 2015, 8:36 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 331991
>     http://bugs.kde.org/show_bug.cgi?id=331991
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> For signed mails the body of the mail has not to change not even slightly.
> 
> BUG: 331991
> FIXED-IN: 15.04
> 
> 
> Diffs
> -----
> 
>   mailcommon/filter/filteractions/filteractionwithcommand.cpp 7b267d9e79f4047c2e621c797bbd6c1c2376eca1 
>   mailcommon/filter/tests/CMakeLists.txt cd149916002ab6976595abba407f5fa3db943c16 
>   mailcommon/filter/tests/actionpipethrough.h PRE-CREATION 
>   mailcommon/filter/tests/actionpipethrough.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122961/diff/
> 
> 
> Testing
> -------
> 
> Adding tests for making sure that pipe through do not change the content of a mail unexpected.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/