[Kde-pim] Review Request 122961: Pipe Through Filter: Do not change mail

[Laurent Montel]

> On mars 15, 2015, 7:38 matin, Laurent Montel wrote:
> > mailcommon/filter/autotests/CMakeLists.txt, line 13
> > <https://git.reviewboard.kde.org/r/122961/diff/2/?file=354981#file354981line13>
> >
> >     For me it needs to use add_akonadi_isolated_test_advanced no ?
> 
> Sandro Knauß wrote:
>     No. The filter actions do not need add_akonadi_isolated_test_advanced, because the filter actions do not interact with akonadi server. The fetch,modify,... jobs that really interact with the akonadi server are done by the mailfilteragent (kdepim/agents/mailfilteragent).

Ok I see.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122961/#review77496
-----------------------------------------------------------


On mars 14, 2015, 11:21 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122961/
> -----------------------------------------------------------
> 
> (Updated mars 14, 2015, 11:21 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 331991
>     http://bugs.kde.org/show_bug.cgi?id=331991
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> For signed mails the body of the mail has not to change not even slightly.
> 
> BUG: 331991
> FIXED-IN: 15.04
> 
> 
> Diffs
> -----
> 
>   mailcommon/filter/autotests/actionpipethrough.cpp PRE-CREATION 
>   mailcommon/filter/filteractions/filteractionwithcommand.cpp 7b267d9e79f4047c2e621c797bbd6c1c2376eca1 
>   mailcommon/filter/autotests/actionpipethrough.h PRE-CREATION 
>   mailcommon/filter/autotests/CMakeLists.txt 29f74d33cc15668924b2143bb568ec625c6af6d1 
> 
> Diff: https://git.reviewboard.kde.org/r/122961/diff/
> 
> 
> Testing
> -------
> 
> Adding tests for making sure that pipe through do not change the content of a mail unexpected.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/