[Kde-pim] Review Request 124137: Make it possible to access OnlineAccounts using QtQuick

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124137/#review81615
-----------------------------------------------------------


Does it make sense to make the plugin optional, so Qml would not be a hard dependency?

Also, there is several style issue ("QObject* parent" -> "QObject *parent"), but it seems to fit exists code.

- Alexandr Akulich


On June 21, 2015, 4:39 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124137/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 4:39 a.m.)
> 
> 
> Review request for KDEPIM and Telepathy.
> 
> 
> Repository: kaccounts-integration
> 
> 
> Description
> -------
> 
> Adds a plugin and an example that uses it. Seems to work.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7431dba 
>   example/accounts.qml PRE-CREATION 
>   src/CMakeLists.txt f28ebb6 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/kaccountsdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kaccountsdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
>   src/jobs/createaccount.h c9d23b6 
>   src/jobs/createaccount.cpp 883283f 
> 
> Diff: https://git.reviewboard.kde.org/r/124137/diff/
> 
> 
> Testing
> -------
> 
> Played around with the example.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/