[Kde-pim] Review Request 124059: todo: fix changing completed after completing

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124059/#review81385
-----------------------------------------------------------


Minor coding style nitpicks. Overall it looks good to me.


src/todo.cpp (line 294)
<https://git.reviewboard.kde.org/r/124059/#comment55759>

    Space between `if` and `(`



src/todo.cpp (line 296)
<https://git.reviewboard.kde.org/r/124059/#comment55760>

    Put `}` and `else` on the same line


- Daniel Vrátil


On June 10, 2015, 2:20 a.m., Paul Eggleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124059/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 2:20 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kcalcore
> 
> 
> Description
> -------
> 
> If you marked a todo as complete, the result was that it could never be
> uncompleted and the percentage could never be set to less than 100%
> because the completed status always overrode this. Do what makes sense
> and set the status when setting the percentage or completed to false.
> 
> 
> Diffs
> -----
> 
>   src/todo.cpp 1dcdbf1 
> 
> Diff: https://git.reviewboard.kde.org/r/124059/diff/
> 
> 
> Testing
> -------
> 
> Created todo items in KOrganizer, edited uncompleted and completed todo items status and percentage complete (with dialog and from list)
> 
> 
> Thanks,
> 
> Paul Eggleton
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/