[Kde-pim] Review Request 124175: Do not try to get audit log for erroneous contexts

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124175/
-----------------------------------------------------------

(Updated June 25, 2015, 2:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Changes
-------

Submitted with commit be886ddf9397ab1ee40a075a1ee34c5c42dea038 by Andre Heinecke to branch KDE/4.14.


Bugs: 347856
    http://bugs.kde.org/show_bug.cgi?id=347856


Repository: kdepim


Description
-------

On error gpgme closes the assuan context of the gpgme context. 
Calling getAuditLog on a closed context leads to a crash. (At least with gpgme 1.5.5)

It's likely that previous versions of gpgme handled this more gracefully. But the behavior is undefined.


Diffs
-----

  libkleo/backends/qgpgme/threadedjobmixin.cpp b48c2d1f49c1e115b9183623da0ae34a0720a627 

Diff: https://git.reviewboard.kde.org/r/124175/diff/


Testing
-------

Looking at an S/MIME Encrypted mail for which I did not have the key triggered this reliably.
The crash can also be reproduced by canceling the pinentry dialog when decrypting an S/MIME mail.


Thanks,

Andre Heinecke

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/