[Kde-pim] Review Request 124179: Kleo: Check for input error in sign/encrypt task

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124179/#review81747
-----------------------------------------------------------


not crazy about triplicating the same code -- rather see a new method fo dealing with the errors

- Allen Winter


On June 25, 2015, 2:38 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124179/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 2:38 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Sign encrypt on an empty input is completly ok
> so we don't get a job error in that case.
> But as the input might be a pre processing command
> like gpgtar the input can fail leading to an empty output.
> With removeInput set to true there is the possibility of
> data loss in that case.
> 
> This fix checks for an inputError string even if the
> sign / encrypt operation has been successfull.
> 
> This is mostly a gpg4win / w32 issue in conjunction
> with gpgtar (which is horribly broken).
> But this can also happen with GNU Tar e.g. when you
> try to archive unreadable input files.
> 
> See: https://bugs.g10code.com/gnupg/issue1624 for
> the report on this issue
> 
> 
> Diffs
> -----
> 
>   kleopatra/crypto/signencryptfilestask.cpp abfa6e4 
>   kleopatra/utils/input.h 0a4a930 
>   kleopatra/utils/input.cpp 751e6f1 
> 
> Diff: https://git.reviewboard.kde.org/r/124179/diff/
> 
> 
> Testing
> -------
> 
> This has been part of the last gpg4win version (released in march). So far no reports about regressions ;-)
> 
> I've also tested this with KDE/4.14 under linux by trying to archive / encrypt files without read permission.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/