[Kde-pim] Review Request 124528: [kdepim] Optionally disable gdrive support at build time

[Andreas Sturmlechner]

> On July 30, 2015, 1:12 a.m., Daniel Vrátil wrote:
> > This does not make much sense, does it? The Storage Service is always built and the GDrive support is enabled depending on whether you have it installed or not. If you don't want GDrive support, you don't need KGAPI library installed at all in which case the GDrive support won't get build. Adding option to support to having KGAPI2 installed but not building GDrive support sounds to me like solving a problem that does not really exist....
> 
> Laurent Montel wrote:
>     Dan is right, it doesn't make sense.
>     You don't want the gdrive support don't install libkgapi.
>     Regards

Admittedly, it is not a very high priority thing. Disabling libkgapi through cmake here means also blogilo will not HAVE_GAPIBLOGGER_SUPPORT. I'm fine with that if you say one find_package(libkgapi) should set google features all across kdepim, this is solved anyway as soon as split packages are available.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124528/#review83163
-----------------------------------------------------------


On July 29, 2015, 10:24 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124528/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 10:24 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> (separately from GAPIBLOGGER_SUPPORT)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7025cbedafb9006b169021e596b98c33fbb784e9 
> 
> Diff: https://git.reviewboard.kde.org/r/124528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/