[Kde-pim] Review Request 124528: [kdepim] Optionally disable gdrive support at build time

Daniel Vrátil dvratil at kde.org
Thu Jul 30 02:12:52 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124528/#review83163
-----------------------------------------------------------


This does not make much sense, does it? The Storage Service is always built and the GDrive support is enabled depending on whether you have it installed or not. If you don't want GDrive support, you don't need KGAPI library installed at all in which case the GDrive support won't get build. Adding option to support to having KGAPI2 installed but not building GDrive support sounds to me like solving a problem that does not really exist....

- Daniel Vrátil


On July 30, 2015, 12:24 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124528/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 12:24 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> (separately from GAPIBLOGGER_SUPPORT)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7025cbedafb9006b169021e596b98c33fbb784e9 
> 
> Diff: https://git.reviewboard.kde.org/r/124528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list