[Kde-pim] Review Request 122187: Restart akonadi when we finish migration.

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122187/#review74500
-----------------------------------------------------------

Ship it!


Thanks for the patch.

Proper fix would probably require ridiculous amount of effort, and restarting Akonadi after something as big as initial migration is perfectly OK in my books.

- Daniel Vrátil


On Jan. 21, 2015, 8:17 p.m., Diane Trout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122187/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 8:17 p.m.)
> 
> 
> Review request for KDEPIM and Christoph Cullmann.
> 
> 
> Bugs: 322471
>     http://bugs.kde.org/show_bug.cgi?id=322471
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This helps with the infinite loop because of resource ids don't match
> reported in kde bug 322471 and debian bug 727800.
> 
> This is a work around, there's probably some better solution possible involving getting akonadi to realize that the resource changed.
> 
> However it is also reasonable to assume that after running the migration enough has changed that restarting akonadi is probably a good idea anyway.
> 
> 
> Diffs
> -----
> 
>   migration/kmail/kmailmigrator.cpp 11c90b8d4e63dd461c6b5ef98404757d788d442c 
> 
> Diff: https://git.reviewboard.kde.org/r/122187/diff/
> 
> 
> Testing
> -------
> 
> I created a virtual machine with debian wheezy and imported a small chunk of email from my imap server. I then upgraded it to jessie, jumping from kdepim-runtime 4.4.11 to 4.14.2. I snapshotted the VM so I could run kmail-migrator --interactive. 
> 
> for a test opened two terminals and in one I did
> $ akonadictl restart
> and in the other I launched
> kmail-migrator --interactive 
> so I could see all the log messages.
> 
> Without the patch akonadi entered an infinite loop eating a significant amount of CPU time with mysql and one of the akonadi processes.
> 
> I added the patch, reinstall kdepim-runtime and With the patch akonadi restarts automatically and when it comes back up it finds the just the new resource and so doesn't 
> 
> I didn't end up with duplicate resources described in 322471 so I don't know if this helps with that or not.
> 
> 
> Thanks,
> 
> Diane Trout
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/