[Kde-pim] Review Request 122224: Use the new method Akonadi::MessageFlags::copyMessageFlags to remove code duplication and fix flags-bugs

Martin Koller kollix at aon.at
Sat Jan 24 13:01:53 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122224/
-----------------------------------------------------------

(Updated Jan. 24, 2015, 1:01 p.m.)


Review request for KDEPIM, KDEPIM-Libraries and Laurent Montel.


Changes
-------

fix memory leak


Bugs: 286692, 313401, 327241, and 342756
    http://bugs.kde.org/show_bug.cgi?id=286692
    http://bugs.kde.org/show_bug.cgi?id=313401
    http://bugs.kde.org/show_bug.cgi?id=327241
    http://bugs.kde.org/show_bug.cgi?id=342756


Repository: kdepim-runtime


Description
-------

As seen in the other review request, this patch uses the new method.
But it also uses the method on places where it was missing before, leading to Akonadi entries without the flags, which are used e.g. in the mail list in kmail.

There are several bug entries on bko which relate to this problem


Diffs (updated)
-----

  resources/mbox/mboxresource.cpp 9b39870 

Diff: https://git.reviewboard.kde.org/r/122224/diff/


Testing
-------

with kmail


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list