[Kde-pim] Review Request 121956: Coding Style for mbox.cpp mbox.h mboxfile.cpp readmbox.cpp stat.h urlinfo.cpp urlinfo.h

Daniel Vrátil dvratil at redhat.com
Mon Jan 19 08:54:43 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121956/#review74292
-----------------------------------------------------------



kioslave/src/mbox/urlinfo.h
<https://git.reviewboard.kde.org/r/121956/#comment51572>

    Maybe split this - one entry per line?



kioslave/src/mbox/urlinfo.h
<https://git.reviewboard.kde.org/r/121956/#comment51571>

    Semicolon should be on the same line as "}"


- Daniel Vrátil


On Jan. 9, 2015, 6:45 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121956/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:45 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Kevin Krammer, Laurent Montel, and Tobias Koenig.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   kioslave/src/mbox/mbox.h 316bafb 
>   kioslave/src/mbox/mbox.cpp ea90def 
>   kioslave/src/mbox/mboxfile.cpp 35753f5 
>   kioslave/src/mbox/readmbox.cpp 50ff350 
>   kioslave/src/mbox/stat.h 837cad3 
>   kioslave/src/mbox/urlinfo.h 99e0e82 
>   kioslave/src/mbox/urlinfo.cpp b4e6d5a 
> 
> Diff: https://git.reviewboard.kde.org/r/121956/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list