[Kde-pim] Review Request 122250: Coding Style for capabilities.cpp capabilities.h command.cpp command.h kioslavesession.cpp kioslavesession.h request.cpp request.h response.cpp response.h smtp.cpp smtp.h smtp_debug.cpp smtp_debug.h smtpsessioninterface.h transactionstate.cpp transactionstate.h

[Guy Maurel]

> On Jan. 28, 2015, 11:01 p.m., Daniel Vrátil wrote:
> > kioslave/src/smtp/capabilities.cpp, line 112
> > <https://git.reviewboard.kde.org/r/122250/diff/1/?file=345026#file345026line112>
> >
> >     Could be reviewboard, but this line seems to be indented one space too much.

no! It is the second part of for (... just under QMap< ...
It is correct


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122250/#review74951
-----------------------------------------------------------


On Jan. 25, 2015, 6:21 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122250/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 6:21 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil, Kevin Krammer, Laurent Montel, and Tobias Koenig.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   kioslave/src/smtp/transactionstate.cpp 47f30257748ece94f02e213b48a8fcd9ec2ea60f 
>   kioslave/src/smtp/smtpsessioninterface.h 11aaac0 
>   kioslave/src/smtp/smtp.cpp 3a0456e 
>   kioslave/src/smtp/smtp_debug.h bbb4a1f 
>   kioslave/src/smtp/capabilities.h f38787a 
>   kioslave/src/smtp/capabilities.cpp 8f9ae92 
>   kioslave/src/smtp/command.h 8f8d9a96d2b1e457acfcc86cd26d58ae9089c54f 
>   kioslave/src/smtp/command.cpp 792b157f762254de645fd6cf27c6bffd5b8bceba 
>   kioslave/src/smtp/kioslavesession.h 9aad59f 
>   kioslave/src/smtp/kioslavesession.cpp 2c9e5c6 
>   kioslave/src/smtp/request.h d0660b9 
>   kioslave/src/smtp/request.cpp 8e5a60a 
>   kioslave/src/smtp/response.h dcd301c 
>   kioslave/src/smtp/response.cpp 3ea226b 
>   kioslave/src/smtp/smtp.h d27674d 
>   kioslave/src/smtp/transactionstate.h 80bdd23 
>   kioslave/src/smtp/smtp_debug.cpp 702ecbf 
> 
> Diff: https://git.reviewboard.kde.org/r/122250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/