[Kde-pim] Review Request 121756: Coding Style for contactviewer.cpp emailaddressselectionproxymodel.cpp emailaddressselectionwidget.cpp leafextensionproxymodel.cpp standardcontactactionmanager.cpp

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121756/#review73138
-----------------------------------------------------------



akonadi-contact/src/contactviewer.cpp
<https://git.reviewboard.kde.org/r/121756/#comment50860>

    The second initializer should be on a new line



akonadi-contact/src/standardcontactactionmanager.cpp
<https://git.reviewboard.kde.org/r/121756/#comment50861>

    This line should be indented one more level, since it's an argument to the function call on the line above.



akonadi-contact/src/standardcontactactionmanager.cpp
<https://git.reviewboard.kde.org/r/121756/#comment50862>

    Same here



akonadi-contact/src/standardcontactactionmanager.cpp
<https://git.reviewboard.kde.org/r/121756/#comment50863>

    Same here



akonadi-contact/src/standardcontactactionmanager.cpp
<https://git.reviewboard.kde.org/r/121756/#comment50864>

    ...and here


- Daniel Vrátil


On Dec. 30, 2014, 3:40 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121756/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 3:40 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-contact/src/contactviewer.cpp bf543bd 
>   akonadi-contact/src/emailaddressselectionproxymodel.cpp b87840b 
>   akonadi-contact/src/emailaddressselectionwidget.cpp 85ff77d 
>   akonadi-contact/src/leafextensionproxymodel.cpp b33670f 
>   akonadi-contact/src/standardcontactactionmanager.cpp b09fdbf 
> 
> Diff: https://git.reviewboard.kde.org/r/121756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/