[Kde-pim] Review Request 122255: fix handling of read-only mbox files

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122255/#review74935
-----------------------------------------------------------

Ship it!


Seems good for me.
Ship it

- Laurent Montel


On jan. 28, 2015, 5:31 après-midi, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122255/
> -----------------------------------------------------------
> 
> (Updated jan. 28, 2015, 5:31 après-midi)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 138445 and 323872
>     http://bugs.kde.org/show_bug.cgi?id=138445
>     http://bugs.kde.org/show_bug.cgi?id=323872
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> The KMBox class did not correctly handle read-only files.
> This patch now tries to first open the file readWrite and if that fails, it retries readOnly.
> 
> This fixes the mentioned bug with mixedmaildir but you now can also open readOnly mbox files with the mbox resource.
> (Using the checkbox "readonly" in mbox resource settings did not work at all)
> 
> 
> Diffs
> -----
> 
>   kmbox/mbox.h d11e454 
>   kmbox/mbox.cpp 60632f3 
>   kmbox/mbox_p.cpp f0e67a0 
>   kmbox/tests/mboxtest.h 6b19153 
>   kmbox/tests/mboxtest.cpp a3b6ee9 
> 
> Diff: https://git.reviewboard.kde.org/r/122255/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/