[Kde-pim] Review Request 122108: Only build tests if BUILD_TESTING is enabled

Heiko Becker heirecka at exherbo.org
Sat Jan 17 13:46:09 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122108/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Otherwise I get

"CMake Error at /usr/share/ECM/modules/ECMMarkAsTest.cmake:40 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  akonadi-imapparsertest
Call Stack (most recent call first):
  autotests/CMakeLists.txt:40 (ecm_mark_as_test)
  autotests/CMakeLists.txt:82 (add_akonadi_test)
..."

if passing -DBUILD_TESTING:BOOL=FALSE.


If this patch is accecpted I would neeed someone to push this for me because I don't have commit access. Thanks in advance.


Diffs
-----

  akonadi/CMakeLists.txt d913fdc 
  akonadi/src/xml/autotests/CMakeLists.txt 6687a82 

Diff: https://git.reviewboard.kde.org/r/122108/diff/


Testing
-------

cmake .. && make && make install


Thanks,

Heiko Becker

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list