[Kde-pim] Review Request 122228: Allow even new Akonadi resources to participate in online/offline mode switching in kmail

[Laurent Montel]

> On jan. 23, 2015, 10:08 après-midi, Laurent Montel wrote:
> > Are you sure that Network is a the good keyword ? Not too generic ?
> > 
> > And please put this test at the end not at the beginning by default we have pop3 and imap and perhaps a day another resource.
> > 
> > Your resource use KMime::Message ? you can see it in kmail ?
> 
> Martin Koller wrote:
>     The ResourceBase method such a resource calls is setNeedsNetwork(true);
>     therefore I think: no, the name is not too generic and tells that the resource needs the network.
>     
>     Have you another suggestion ?
>     
>     About the test: I was thinking about removal of the old checks completely - but then this might lead to some
>     upwards compatibility problem if one upgrades kmail but not the resources with new .desktop files (which I did not yet include in the diff).
>     I add the check at the end.
>     
>     Regarding my new resource: yes, it uses KMime::Message and yes, I can see and use it in kmail.
>     
>     It implements the possibility to use the AirSync protocol (aka Exchange Active Sync) to download mails from such a server
>     (which is what I need for my company account)
> 
> Martin Koller wrote:
>     Thinking further ... probably "NeedsNetwork" would also be an idea.

Yes "NeedsNetwork" seems better for me


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122228/#review74638
-----------------------------------------------------------


On jan. 23, 2015, 10:23 après-midi, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122228/
> -----------------------------------------------------------
> 
> (Updated jan. 23, 2015, 10:23 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Currently kmail has only a hardcoded check for pop3 and imap resources when switching online/offline mode.
> That means new resources can not participate in this switching.
> 
> With introducing a new capability Label in a resources .desktop file, kmail can now check for all resources which have this flag set and use this to switch all even now unknown ones online or offline.
> 
> I've also prepared changes in Akonadi::AgentType code to include a new named static variable, however
> this would mean kmail depends on a newer version of akonadi and I'm not sure if this is a good idea in a bugfix branch.
> 
> Maybe the change to Akonadi::AgentType should only go into master.
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.cpp 4d631c4 
> 
> Diff: https://git.reviewboard.kde.org/r/122228/diff/
> 
> 
> Testing
> -------
> 
> kmail and my new AirSync resource
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/