[Kde-pim] Review Request 122223: add Akonadi::MessageFlags::copyMessageFlags() which is needed in a lot places all over kdepim code

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122223/
-----------------------------------------------------------

(Updated Jan. 31, 2015, 12:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Laurent Montel.


Repository: kdepimlibs


Description
-------

During my investigation of several problems with kmail correctly displaying email flags, I encountered a lot of places where there were code duplication doing all the same steps to copy mail flags from a KMime::Message into an Akonadi::Item.

To get rid of this code duplication, I created a new method.

I'll create review requests for the other repos as well (kdepim-runtime, kdepim)


Diffs
-----

  kmime/tests/auto/CMakeLists.txt 7469914 
  kmime/tests/auto/messagetest.h 1fb0a69 
  kmime/tests/auto/messagetest.cpp 91d5f72 
  mailtransport/messagequeuejob.cpp 9265440 
  kmime/kmime_util.cpp d68588c 
  akonadi/kmime/messageflags.h 39e2df3 
  akonadi/kmime/messageflags.cpp 86c79df 
  kmime/kmime_util.h 9fb071a 

Diff: https://git.reviewboard.kde.org/r/122223/diff/


Testing
-------

with kmail


File Attachments
----------------

signed.mbox
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/31/9cd6e3df-b70b-4c0d-b67f-40ae58227dfe__signed.mbox


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/