[Kde-pim] Review Request 122047: Fix encoding for non-ascii filenames for TNEF.

Laurent Montel montel at kde.org
Wed Jan 14 06:11:21 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122047/#review73985
-----------------------------------------------------------


Your tests file is empty in patch.
So I can't test it for the moment.

- Laurent Montel


On jan. 13, 2015, 10:03 après-midi, Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122047/
> -----------------------------------------------------------
> 
> (Updated jan. 13, 2015, 10:03 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Correctly decode attachement filenames as Latin1. Adding a unit test
> to ensure this.
> 
> This patch is connected to review request 121937 that I will adapt, once this fix is committed.
> 
> 
> Diffs
> -----
> 
>   ktnef/ktnefparser.cpp 4faebaffa3eba3da07bf2daa2c743f4ab287eb56 
>   ktnef/tests/parsertest.h 181a57ef1c5bf5d1f553564ea1903196fdc09ee5 
>   ktnef/tests/parsertest.cpp efa3053430a804eb1297f3af3a68e5a68dcec09a 
>   ktnef/tests/umlaut-filename.tnef PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122047/diff/
> 
> 
> Testing
> -------
> 
> unit test
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list