[Kde-pim] Review Request 121863: Review KXmlRpcClient before submitting for Frameworks

[Aleix Pol Gonzalez]

> On Jan. 7, 2015, 7:14 a.m., Laurent Montel wrote:
> > CMakeLists.txt, line 23
> > <https://git.reviewboard.kde.org/r/121863/diff/3/?file=338623#file338623line23>
> >
> >     Why remove it ?

It's provided by ECM now, explicitly adding it only makes us have it twice.


> On Jan. 7, 2015, 7:14 a.m., Laurent Montel wrote:
> > src/client.cpp, line 215
> > <https://git.reviewboard.kde.org/r/121863/diff/3/?file=338631#file338631line215>
> >
> >     arg.at(i) perhaps.

why?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121863/#review73322
-----------------------------------------------------------


On Jan. 6, 2015, 12:12 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121863/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 12:12 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Aleix Pol Gonzalez and Laurent Montel.
> 
> 
> Repository: kxmlrpcclient
> 
> 
> Description
> -------
> 
> Forward-declare KIO::Job and KJob in public headers
> 
> 
> Avoid unnecessary conversion from QUrl to QString and back to QUrl
> 
> 
> Add metainfo.yaml
> 
> 
> CMake: remove definitions provided by ECM
> 
> 
> Update README, switch to MD format, rename to README.MD
> 
> 
> Move private classes to query_p.h to make them testable
> 
> 
> Make parser/serializer methods in Query::Private static
> Simplifies testing
> 
> 
> Initialize members of KXmlRpc::Response
> 
> 
> Rename unit tests and simplify CMake
> 
> 
> Add testcases for Query::Private parser/serializer
> 
> 
> Only parse fault response once
> 
> 
> Build the output XML as QByteArray instead of QString
> We need to convert the markup to QByteArray anyway in order to pass it to
> KIO::http_post, so we can build it right away. It should be slightly
> faster and more memory efficient than QString.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 94dfd41 
>   README ae79831 
>   autotests/CMakeLists.txt 3f12c82 
>   autotests/testclient.h 89a5e5b 
>   autotests/testclient.cpp 8804b5b 
>   autotests/testquery.h 91bf32b 
>   autotests/testquery.cpp 494ee4c 
>   metainfo.yaml PRE-CREATION 
>   src/client.cpp 60e32f3 
>   src/query.h d8d13bc 
>   src/query.h d8d13bc 
>   src/query.cpp 9c24155 
> 
> Diff: https://git.reviewboard.kde.org/r/121863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/