[Kde-pim] Review Request 122228: Allow even new Akonadi resources to participate in online/offline mode switching in kmail

Martin Koller kollix at aon.at
Fri Jan 23 22:23:00 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122228/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 10:23 p.m.)


Review request for KDEPIM and Laurent Montel.


Changes
-------

put check as last


Repository: kdepim


Description
-------

Currently kmail has only a hardcoded check for pop3 and imap resources when switching online/offline mode.
That means new resources can not participate in this switching.

With introducing a new capability Label in a resources .desktop file, kmail can now check for all resources which have this flag set and use this to switch all even now unknown ones online or offline.

I've also prepared changes in Akonadi::AgentType code to include a new named static variable, however
this would mean kmail depends on a newer version of akonadi and I'm not sure if this is a good idea in a bugfix branch.

Maybe the change to Akonadi::AgentType should only go into master.


Diffs (updated)
-----

  kmail/kmkernel.cpp 4d631c4 

Diff: https://git.reviewboard.kde.org/r/122228/diff/


Testing
-------

kmail and my new AirSync resource


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list