[Kde-pim] Review Request 122223: add Akonadi::MessageFlags::copyMessageFlags() which is needed in a lot places all over kdepim code
Laurent Montel
montel at kde.org
Fri Jan 23 16:06:38 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122223/#review74606
-----------------------------------------------------------
akonadi/kmime/messageflags.h
<https://git.reviewboard.kde.org/r/122223/#comment51715>
4.14.5
akonadi/kmime/messageflags.h
<https://git.reviewboard.kde.org/r/122223/#comment51716>
could you create an unitest for it please ?
- Laurent Montel
On jan. 23, 2015, 3:58 après-midi, Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122223/
> -----------------------------------------------------------
>
> (Updated jan. 23, 2015, 3:58 après-midi)
>
>
> Review request for KDEPIM-Libraries and Laurent Montel.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> During my investigation of several problems with kmail correctly displaying email flags, I encountered a lot of places where there were code duplication doing all the same steps to copy mail flags from a KMime::Message into an Akonadi::Item.
>
> To get rid of this code duplication, I created a new method.
>
> I'll create review requests for the other repos as well (kdepim-runtime, kdepim)
>
>
> Diffs
> -----
>
> akonadi/kmime/messageflags.h 39e2df3
> akonadi/kmime/messageflags.cpp 86c79df
> mailtransport/messagequeuejob.cpp 9265440
>
> Diff: https://git.reviewboard.kde.org/r/122223/diff/
>
>
> Testing
> -------
>
> with kmail
>
>
> Thanks,
>
> Martin Koller
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list