[Kde-pim] Review Request 122231: Use ecm_optional_add_subdirectory to allow disabling parts of kdepim

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122231/#review74642
-----------------------------------------------------------


I am against it.
It's not really useful.
I removed it because I didn't want it. We can't test all case so it will create more bug that useful.
So sorry no.

Regards.

- Laurent Montel


On jan. 23, 2015, 9:07 après-midi, Bernd Steinhauser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122231/
> -----------------------------------------------------------
> 
> (Updated jan. 23, 2015, 9:07 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> kdepim is a very large thing, so it is desirable to have the possibility to deactivate some parts.
> In KDE4, macro_optional_add_subdirectory was used for this but during the migration was converted to an unconditional add_subdirectory.
> The patch changes this behaviour by using the function ecm_optional_add_subdirectory provided by extra-cmake-modules.
> 
> I performed this change for every subdir, that was previously using the afore-mentioned macro. 
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4988004 
> 
> Diff: https://git.reviewboard.kde.org/r/122231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Steinhauser
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/