[Kde-pim] Review Request 121863: Review KXmlRpcClient before submitting for Frameworks

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121863/#review73220
-----------------------------------------------------------


It looks good, it will be easier to review if you pass --find-copies-harder.


autotests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121863/#comment50923>

    You can use ecm_add_test() there if you want


- Aleix Pol Gonzalez


On Jan. 5, 2015, 5:43 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121863/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 5:43 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Aleix Pol Gonzalez and Laurent Montel.
> 
> 
> Repository: kxmlrpcclient
> 
> 
> Description
> -------
> 
> Forward-declare KIO::Job and KJob in public headers
> 
> 
> Avoid unnecessary conversion from QUrl to QString and back to QUrl
> 
> 
> Add metainfo.yaml
> 
> 
> CMake: remove definitions provided by ECM
> 
> 
> Update README, switch to MD format, rename to README.MD
> 
> 
> Move private classes to query_p.h to make them testable
> 
> 
> Make parser/serializer methods in Query::Private static
> Simplifies testing
> 
> 
> Initialize members of KXmlRpc::Response
> 
> 
> Rename unit tests and simplify CMake
> 
> 
> Add testcases for Query::Private parser/serializer
> 
> 
> Only parse fault response once
> 
> 
> Build the output XML as QByteArray instead of QString
> We need to convert the markup to QByteArray anyway in order to pass it to
> KIO::http_post, so we can build it right away. It should be slightly
> faster and more memory efficient than QString.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 94dfd411114ec19c064d44ba3f41d3d4c78350bc 
>   README ae79831fa7796bb3fd8a1eba1e7c8b68b634399a 
>   autotests/CMakeLists.txt 3f12c824e0040258049e7a9dad569d31803c301b 
>   autotests/querytest.cpp PRE-CREATION 
>   autotests/testclient.h 89a5e5b45925f2f7828ff7de7237b502a1854909 
>   autotests/testclient.cpp 8804b5bd061f91594950d92432cb71b1e71d83d4 
>   autotests/testquery.h 91bf32b346c1df5d128dd83a741a06be331a5ccd 
>   autotests/testquery.cpp 494ee4caac17748172874f5d28d07cb2caf52748 
>   metainfo.yaml PRE-CREATION 
>   src/client.cpp 60e32f350ffd4f42a85d53caefa7386f9469fc72 
>   src/query.h d8d13bc62c8d2b6986aa73ef2c6ab0118fae0056 
>   src/query.cpp 9c2415577b49e891def54e84baf0def24c2a0897 
>   src/query_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/