[Kde-pim] Review Request 121937: Fix links to files in TNEF attachements with non-asci characters

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121937/#review74966
-----------------------------------------------------------

Ship it!


I tested it and it's ok.
Please commit in 4.14 and I will merge in master.
Regards

- Laurent Montel


On jan. 28, 2015, 8:14 après-midi, Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121937/
> -----------------------------------------------------------
> 
> (Updated jan. 28, 2015, 8:14 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This patch fixes the generated file links for files in TNEF attachments containing non-ascii-charcters. With this patch, the same file naming scheme is applied as used in KNefParser::extractAttachementTo(...) which first uses att->fileName() and att->file() only as a fallback. The patch contains fixes for all code snippets in KDEPIM using KTNEFParser::extractFileTo(...).
> 
> For the Qt5 based development I would propose to change this patch again, i.e., to change the API of KTNEFParser to return a proper path to the extracted file. (However, that would be a change in KDEPIMlibs and probably too invasive for the 4.14 branch.) That would also allow to get code that can be much easier unit-tested.
> 
> 
> Diffs
> -----
> 
>   ktnef/ktnefmain.cpp 8c89cd4 
>   plugins/messageviewer/bodypartformatter/application_ms-tnef.cpp 9692f65 
> 
> Diff: https://git.reviewboard.kde.org/r/121937/diff/
> 
> 
> Testing
> -------
> 
> Tested manually with a TNEF attachement containing German umlauts in file names.
> 
> 
> File Attachments
> ----------------
> 
> Test Mail
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/e15d4abb-bd12-472b-b4da-cefbb264bf19__tnef.mbox
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/