[Kde-pim] Review Request 122231: Use ecm_optional_add_subdirectory to allow disabling parts of kdepim

[Bernd Steinhauser]

> On Jan. 23, 2015, 10:16 p.m., Laurent Montel wrote:
> > I am against it.
> > It's not really useful.
> > I removed it because I didn't want it. We can't test all case so it will create more bug that useful.
> > So sorry no.
> > 
> > Regards.

Ok, I see. What about a reduced patch to reduce the varity of options, but at least allow to disable some parts?

Reason is, that kdepim right now is huge and takes over 2h for me to compile.

I.e. I have no interest in testing blogilo (which needs libkgapi, which I'm also not interested in), knotes and kontact/korganizer.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122231/#review74642
-----------------------------------------------------------


On Jan. 23, 2015, 9:07 p.m., Bernd Steinhauser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122231/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 9:07 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> kdepim is a very large thing, so it is desirable to have the possibility to deactivate some parts.
> In KDE4, macro_optional_add_subdirectory was used for this but during the migration was converted to an unconditional add_subdirectory.
> The patch changes this behaviour by using the function ecm_optional_add_subdirectory provided by extra-cmake-modules.
> 
> I performed this change for every subdir, that was previously using the afore-mentioned macro. 
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4988004 
> 
> Diff: https://git.reviewboard.kde.org/r/122231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Steinhauser
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/