[Kde-pim] Review Request 122422: Split backends code into a separate binary
Martin Klapetek
martin.klapetek at gmail.com
Wed Feb 4 12:49:45 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122422/#review75385
-----------------------------------------------------------
+1
(if nobody else comments/objects, consider that a ship it)
- Martin Klapetek
On Feb. 4, 2015, 1:13 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122422/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:13 p.m.)
>
>
> Review request for KDEPIM and Telepathy.
>
>
> Repository: libkpeople
>
>
> Description
> -------
>
> If KPeople has to become a framework, we'll need to maintain ABI.
> This patch adds a separate library so we can eventually extend the backends without comprimising KPeople adoption.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 82a987a
> src/CMakeLists.txt 7b4f951
> src/backends/CMakeLists.txt PRE-CREATION
> src/defaultcontactmonitor.cpp
> src/defaultcontactmonitor_p.h cc78afb
> src/widgets/CMakeLists.txt 016a8c5
>
> Diff: https://git.reviewboard.kde.org/r/122422/diff/
>
>
> Testing
> -------
>
> Builds. Tests run.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list