[Kde-pim] Review Request 122391: Drop Qt5::Widgets dependency from KPeople main library

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122391/#review75240
-----------------------------------------------------------

Ship it!


Note that actions on subcontacts in contact list are broken, it has to do with requiring PersonData for the actions now because for a subcontact, PersonData should return its own Person, ie the parent contact (that was the original design), that's something that should be looked into

- Martin Klapetek


On Feb. 2, 2015, 7:26 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122391/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 7:26 p.m.)
> 
> 
> Review request for KDEPIM and Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Moves the QActions facilities to KPeopleWidgets, this way KPeople organization makes more sense, as we already had a KPeopleWidgets anyway.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt fb8db35 
>   src/backends/abstractpersonaction.h 396190d 
>   src/declarative/CMakeLists.txt 8fd4bf4 
>   src/declarative/personactionsmodel.cpp 8120605 
>   src/global.h 52ff586 
>   src/global.cpp b5335b2 
>   src/persondata.h 450f4d3 
>   src/personpluginmanager.cpp 6469138 
>   src/widgets/CMakeLists.txt bceca8c 
>   src/widgets/actions.h PRE-CREATION 
>   src/widgets/actions.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122391/diff/
> 
> 
> Testing
> -------
> 
> Seems to work, requires trivial patches to ktp-common-internals and ktp-contact-list.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/