[Kde-pim] Review Request 126454: Handle signed only inline messages correctly

Daniel Vrátil dvratil at kde.org
Mon Dec 28 12:00:46 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126454/#review90205
-----------------------------------------------------------

Ship it!


Looks good to me.

- Daniel Vrátil


On Dec. 21, 2015, 5:14 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126454/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 5:14 p.m.)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Bugs: 333611
>     http://bugs.kde.org/show_bug.cgi?id=333611
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> In a PGP MESSAGE block can also only be a signed only message. So if the decyption
> fails but a signature is availabe it is a signed only part.
> 
> BUG: 333611
> 
> 
> Diffs
> -----
> 
>   messageviewer/autotests/data/openpgp-encoded.mbox PRE-CREATION 
>   messageviewer/autotests/data/openpgp-encoded.mbox.html PRE-CREATION 
>   messageviewer/src/viewer/objecttreeparser.cpp 067c113c89722027e355f119a249aab9b5ce6b29 
> 
> Diff: https://git.reviewboard.kde.org/r/126454/diff/
> 
> 
> Testing
> -------
> 
> create testcase - made sure that test breaks 
> create patch test if test passes.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list