[Kde-pim] Review Request 126451: Don't endup in a endless loop for inline signed messages

Laurent Montel montel at kde.org
Mon Dec 21 21:37:43 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126451/#review89863
-----------------------------------------------------------

Ship it!


Seems ok.
Ship it

- Laurent Montel


On déc. 21, 2015, 12:02 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126451/
> -----------------------------------------------------------
> 
> (Updated déc. 21, 2015, 12:02 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Bugs: 356093
>     http://bugs.kde.org/show_bug.cgi?id=356093
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> For inline signed messages the reference node is a null pointer
> so we also need to set the memento for this null sign pointer, to
> be able to refind the memento again.
> 
> 
> Diffs
> -----
> 
>   messageviewer/autotests/objecttreeparsertest.h d9204917dea2677b00c35a7b247dc5ac3593010c 
>   messageviewer/autotests/objecttreeparsertest.cpp c0cb5998c864b9cdef3fc6c9789d1ba99adc9e01 
>   messageviewer/src/viewer/objecttreeparser.cpp 067c113c89722027e355f119a249aab9b5ce6b29 
> 
> Diff: https://git.reviewboard.kde.org/r/126451/diff/
> 
> 
> Testing
> -------
> 
> building + running tests before/after, to make sure the test hit the problem.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list