[Kde-pim] Review Request 124928: Use toLocal8Bit/fromLocal8Bit for POSIX API

Dāvis Mosāns davispuh at gmail.com
Wed Aug 26 03:34:53 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124928/
-----------------------------------------------------------

Review request for Akonadi.


Repository: akonadi


Description
-------

Use toLocal8Bit/fromLocal8Bit for POSIX API
When user have non-latin username it would create folder /tmp/akonadi-* with wrong encoding.
This fixes it by using fromLocal8Bit which will convert to QString from LANG encoding.


Diffs
-----

  src/server/akonadi.cpp a4f0e8cb88053d6a4c575f46fa9e521dee1a6402 
  src/server/utils.cpp 1195cd7546ba7dd0637238c7d9371d454d1f5d06 

Diff: https://git.reviewboard.kde.org/r/124928/diff/


Testing
-------

Compiles and correctly created folder /tmp/akonadi-D?vis.FurEKd/ for username D?vis (PS. that "?" is messed up by reviewboard)
Only it fails on listen(socketFile) because QLocalServer incorrectly uses toLatin1 for POSIX API.
I created a patch for it https://codereview.qt-project.org/#/c/124230/


Thanks,

Dāvis Mosāns

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list