[Kde-pim] Review Request 124952: libkleo: Port cryptoconfigdialog to QDialog
Laurent Montel
montel at kde.org
Thu Aug 27 15:16:11 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124952/#review84475
-----------------------------------------------------------
libkleo/ui/cryptoconfigmodule.cpp (line 928)
<https://git.reviewboard.kde.org/r/124952/#comment58475>
Why ?
we can't use default button/icon from QDialogButtonBox ?
- Laurent Montel
On août 27, 2015, 1:47 après-midi, Andre Heinecke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124952/
> -----------------------------------------------------------
>
> (Updated août 27, 2015, 1:47 après-midi)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> This is the last remaining usage of KDialog in libkleo
>
> Minor functionality change is that a read only Keyserver widget now behaves the same as the ldap dialog with regards to shown buttons.
>
>
> Diffs
> -----
>
> libkleo/ui/cryptoconfigmodule.cpp be4f84d
>
> Diff: https://git.reviewboard.kde.org/r/124952/diff/
>
>
> Testing
> -------
>
> Compiles, tried out both dialogs look the same as before.
>
>
> Thanks,
>
> Andre Heinecke
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list