[Kde-pim] Review Request 123451: MessageComposer: Expand groups

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123451/#review79330
-----------------------------------------------------------



messagecomposer/composer/composerlineedit.h (line 43)
<https://git.reviewboard.kde.org/r/123451/#comment54158>

    add const.



messagecomposer/composer/composerlineedit.cpp (line 63)
<https://git.reviewboard.kde.org/r/123451/#comment54159>

    use new connect api



messagecomposer/composer/composerlineedit.cpp (line 171)
<https://git.reviewboard.kde.org/r/123451/#comment54160>

    Why change new connect api to old connect api ?



messagecomposer/composer/composerlineedit.cpp (line 197)
<https://git.reviewboard.kde.org/r/123451/#comment54161>

    why change coding style here ?



messagecomposer/composer/composerlineedit.cpp (line 229)
<https://git.reviewboard.kde.org/r/123451/#comment54162>

    const'ref here.



messagecomposer/composer/composerlineedit.cpp (line 232)
<https://git.reviewboard.kde.org/r/123451/#comment54174>

    new connect api



messagecomposer/composer/composerlineedit.cpp (line 240)
<https://git.reviewboard.kde.org/r/123451/#comment54163>

    indent here. => coding style. We use kdelibs-astyle for it



messagecomposer/composer/composerlineedit.cpp (line 262)
<https://git.reviewboard.kde.org/r/123451/#comment54164>

    const'ref



messagecomposer/composer/composerlineedit.cpp (line 264)
<https://git.reviewboard.kde.org/r/123451/#comment54165>

    new connect api



messagecomposer/composer/composerlineedit.cpp (line 268)
<https://git.reviewboard.kde.org/r/123451/#comment54166>

    Use QStringLiteral herE.



messagecomposer/composer/composerlineedit.cpp (line 293)
<https://git.reviewboard.kde.org/r/123451/#comment54167>

    new connect api



messagecomposer/composer/composerlineedit.cpp (line 295)
<https://git.reviewboard.kde.org/r/123451/#comment54168>

    !isEmpty



messagecomposer/composer/composerlineedit.cpp (line 297)
<https://git.reviewboard.kde.org/r/123451/#comment54169>

    new xconnect api



messagecomposer/composer/composerlineedit.cpp (line 357)
<https://git.reviewboard.kde.org/r/123451/#comment54170>

    const here.



messagecomposer/recipient/recipientline.h (line 122)
<https://git.reviewboard.kde.org/r/123451/#comment54171>

    Q_SLOTS



messagecomposer/recipient/recipientline.cpp (line 106)
<https://git.reviewboard.kde.org/r/123451/#comment54172>

    new connect api



messagecomposer/recipient/recipientline.cpp (line 118)
<https://git.reviewboard.kde.org/r/123451/#comment54173>

    Q_EMIT


- Laurent Montel


On avr. 21, 2015, 4:28 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123451/
> -----------------------------------------------------------
> 
> (Updated avr. 21, 2015, 4:28 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> (part of the ongoing getting kolab patches to kdepim)
> ContactGroups should be possible to expand to different to fields.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer/composerlineedit.h a8c2c134eed4513b9e98348262612d8e7431a5a8 
>   messagecomposer/composer/composerlineedit.cpp 639ca2f73adbc2d13ba7c6c32322950473470010 
>   messagecomposer/recipient/recipientline.h 24fba9816c7a67af62abd37930be30935f6ade69 
>   messagecomposer/recipient/recipientline.cpp 746d99d4e799be137036fa5e0735589bdf7f7749 
>   messagecomposer/recipient/recipientseditor.h 66cc0de5dba85cadbe44064cd7d74a6abc37957d 
>   messagecomposer/recipient/recipientseditor.cpp 588f6ff5db53b5bfd08bae85cad31fa0c82ac0fe 
> 
> Diff: https://git.reviewboard.kde.org/r/123451/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/