[Kde-pim] Review Request 123484: Re-imported modified collectionsearchjob from zanshin to be shared.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123484/#review79593
-----------------------------------------------------------



libkdepim/job/collectionsearchjob.h (line 36)
<https://git.reviewboard.kde.org/r/123484/#comment54377>

    coding style QObject *parent.



libkdepim/job/collectionsearchjob.cpp (line 86)
<https://git.reviewboard.kde.org/r/123484/#comment54380>

    error => emitResult(); return ?



libkdepim/job/collectionsearchjob.cpp (line 117)
<https://git.reviewboard.kde.org/r/123484/#comment54378>

    There is an error. 
    Perhaps we need to emitResult() and return here no ?



libkdepim/job/personsearchjob.h (line 37)
<https://git.reviewboard.kde.org/r/123484/#comment54379>

    coding style QObject *parent


- Laurent Montel


On avr. 27, 2015, 3:56 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123484/
> -----------------------------------------------------------
> 
> (Updated avr. 27, 2015, 3:56 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> (cherry picked from commit 30e818f9f6eddb3822f62f1aafabbd39029f1a51)
> 
> Re-importet modified personsearchjob from zanshin.
> 
> (cherry picked from commit 720ea7a504dbf097312fb75fa67313ee321bf15d)
> 
> Use personsearchjob and collectionsearchjob from libkdepim.
> 
> (cherry picked from commit c382227777ac9c8bfa18e3787434dc260a2be862)
> 
> move to frameworks
> 
> 
> Diffs
> -----
> 
>   libkdepim/CMakeLists.txt 271dbd00c5a8b0fd811268c6b1d73f7d9918e374 
>   libkdepim/job/collectionsearchjob.h PRE-CREATION 
>   libkdepim/job/collectionsearchjob.cpp PRE-CREATION 
>   libkdepim/job/person.h PRE-CREATION 
>   libkdepim/job/personsearchjob.h PRE-CREATION 
>   libkdepim/job/personsearchjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/