[Kde-pim] Review Request 123558: kolabchanges: messageviewer [4/4]

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123558/#review79674
-----------------------------------------------------------



kmail/kmmainwidget.cpp (line 135)
<https://git.reviewboard.kde.org/r/123558/#comment54506>

    it's a changes which is not in relation which this patch.
    And I am against to this changes.
    we can't change tag into dialog
    => we can create but not specify color/shortcut etc.
    => this part will not commit in kmail.



kmail/messageactions.cpp 
<https://git.reviewboard.kde.org/r/123558/#comment54507>

    How we migrate old annotation from email now ?


- Laurent Montel


On avr. 29, 2015, 12:27 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123558/
> -----------------------------------------------------------
> 
> (Updated avr. 29, 2015, 12:27 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create notes from email
> * show close instead of cancel
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 20ecca9414eff7a50133e1cdd221d098d40aa34b 
>   kmail/messageactions.h 3a8c6d2694a852f5637451227a4bd4b0f878c56d 
>   kmail/messageactions.cpp f32dbb5e4322b3600a156ca171380a2725a78c02 
>   messageviewer/settings/messageviewer.kcfg.cmake 1b0d50163d48b6442b3386abd19f7a2c1c558462 
>   messagelist/core/messageitem_p.h d64084ebee5c3fc8ced27915cfc42e06fc0ed1d2 
>   messagelist/core/messageitem.cpp 0ae315c3f40a33b366ce2870c4700d444110d1fb 
>   messageviewer/CMakeLists.txt 2b35645d3490e12f13d8779302871e1d385ccb50 
> 
> Diff: https://git.reviewboard.kde.org/r/123558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/