[Kde-pim] Review Request 123571: Added myRights support

Sandro Knauß knauss at kolabsys.com
Thu Apr 30 15:22:40 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123571/
-----------------------------------------------------------

(Updated April 30, 2015, 2:22 nachm.)


Review request for KDEPIM, Christian Mollekopf and Laurent Montel.


Changes
-------

merged tests from kdepim-runtime, but they failed.
That's why I have changed the logic of the serializer, that only myRights is added, when it is not null.

@christian: are the serializer/deserializer tests ok?

Afterwards approving here I'll copy the tests also to kdepim-runtime.


Repository: kdepim


Description (updated)
-------

Moved/merged new version of imapaclattribute with tests from kdepim-runtime:
resources/shared/singlefileresource/imapaclattribute.*


Diffs (updated)
-----

  pimcommon/acl/autotests/imapaclattributetest.h 16862e8fec0f0761e4392ccbe44fff8770bed299 
  pimcommon/acl/autotests/imapaclattributetest.cpp f715f8a4adeced7252d25022c3008f27910ec89e 
  pimcommon/acl/imapaclattribute.h f922d6c4a3ae5a88051a5df686c52e6983763dcc 
  pimcommon/acl/imapaclattribute.cpp df3176a01dc228fa71c429ccdb9ecd4756c0e31b 

Diff: https://git.reviewboard.kde.org/r/123571/diff/


Testing
-------


Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list