[Kde-pim] Review Request 123334: Make kmime build on OSX
Christophe Giboudeaux
cgiboudeaux at gmx.com
Sat Apr 11 18:29:20 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123334/#review78827
-----------------------------------------------------------
KF5MimeConfig.cmake.in shall also mention that boost is needed
CMakeLists.txt (lines 38 - 43)
<https://git.reviewboard.kde.org/r/123334/#comment53923>
Not needed here. ${Boost_INCLUDE_DIR} should be added to the target_include_directories line instead.
- Christophe Giboudeaux
On avr. 11, 2015, 3:57 après-midi, Marko Käning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123334/
> -----------------------------------------------------------
>
> (Updated avr. 11, 2015, 3:57 après-midi)
>
>
> Review request for KDEPIM-Libraries and Laurent Montel.
>
>
> Repository: kmime
>
>
> Description
> -------
>
> At least here on OSX/CI one needs to tell kmime that it requires boost.
>
> (Sorry for the whitespace changes, but they came in due to indendation cleanup.)
>
>
> Diffs
> -----
>
> CMakeLists.txt 39cd7f3b9ff12f10af12ba4ed50b2c4eb6ae714a
>
> Diff: https://git.reviewboard.kde.org/r/123334/diff/
>
>
> Testing
> -------
>
> Built fine on my MacPorts-based OSX/CI.
>
>
> Thanks,
>
> Marko Käning
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list