[Kde-pim] Review Request 123483: patches for libkdepim/ldap

Laurent Montel montel at kde.org
Fri Apr 24 14:22:05 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123483/#review79440
-----------------------------------------------------------

Ship it!


Seems good.
Ship it

- Laurent Montel


On avr. 24, 2015, 7:31 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123483/
> -----------------------------------------------------------
> 
> (Updated avr. 24, 2015, 7:31 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> make ldap settings available for other apps 
> 
> ldapclientsearchconfig: not show the question for storing passwords
> 
> Do not show the question for storing passwords in KWallet for LDAP
> (need for tests)
> 
> We wanna use these things in tests and in accountwizard.
> 
> 
> Diffs
> -----
> 
>   libkdepim/CMakeLists.txt 271dbd00c5a8b0fd811268c6b1d73f7d9918e374 
>   libkdepim/ldap/addhostdialog.cpp 5949391c3a24def611d66667c87a37df2e858aa6 
>   libkdepim/ldap/addhostdialog_p.h 008e0199922fd5ec8605a61cd6913818ce361c93 
>   libkdepim/ldap/kcmldap.cpp b114034f3a003a122973565aa69c1540825cc83a 
>   libkdepim/ldap/ldapclientsearchconfig.h 36d88a3e919a3c502ce98bf239cd5e1b4d80d780 
>   libkdepim/ldap/ldapclientsearchconfig.cpp 9a579aac3ae743bb38a698b2ac2c670980ed1887 
> 
> Diff: https://git.reviewboard.kde.org/r/123483/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list